Collection, current location - Getty Center, J. Paul Getty Museum

should be vice versa, see example: File:Anthony van Dyck - Thomas Howard, 2nd Earl of Arundel - 86.PA.532 - J. Paul Getty Museum.jpg --Oursana (talk) 20:25, 26 February 2022 (UTC)

TODO: better integration with {{ProvenanceEvent}}

• / organizer (P664) somevalue qualifier -> |atunknown= (testcase: Girl with a Pearl Earring (Q185372))
• support multiple qualifiers of same property
• find equivalent of |result= on Wikidata and use here (looking at the values of has effect (P1542) qualifiers (query it might be an option, but has not been used that way yet; a generalization of results (P2501) would be another option, probably best discuss at d:WT:WPVA)
• find equivalent(s) of |through= on Wikidata and use here
• find equivalent(s) of |by= on Wikidata and use here
• use simple creator (P170) qualifiers as equivalent of |as=???
• implement use of sourcing circumstances (P1480) (et al.?) for |status= (query for values on Commons; query for values on WD: values like circa (Q5727902) should not be used for |status=, probably set a tracking category to find out which values will actually show on Commons; example: File:Batalla hochkirch.jpg)

… in case me or someone else is looking for some useful improvements to work on. :-) --Marsupium (talk) 10:38, 18 December 2023 (UTC), 16:27, 19 September 2025 (UTC)

Another remark: deposit (Q5260774): making a cash deposit in a financial institution looks wrong as the item for "deposit". --Marsupium (talk) 11:09, 7 January 2024 (UTC)

Maybe use Module:Formatnum to format the value of price (P2284). --Marsupium (talk) 13:53, 26 October 2024 (UTC)

Hello Jarekt, I have changed the sandbox to display normal but not best rank owned by (P127) statements and Template:ProvenanceEvent's |atunknown= (example for both: File:1665 Girl with a Pearl Earring.jpg). For those I have added a parameter and an additional output field to function getPropertyQual(). If you like take a look to see if you think the changes go into the right direction. Thanks in advance, --Marsupium (talk) 13:21, 19 September 2025 (UTC)

Marsupium Those are good improvements. --Jarekt (talk) 00:08, 20 September 2025 (UTC)

Thank you, I have deployed the changes for now. {{ProvenanceEvent}} integration could still profit from more detail work and probably a Lua rewrite in the future, but step by step. --Marsupium (talk) 09:35, 20 September 2025 (UTC)

"edit at Wikidata icon" missing for function p.get_institution()

I've noticed this inconsistency once in a while, so now leaving a note here for the next time me or someone else feels like adding it. --Marsupium (talk) 10:01, 6 January 2024 (UTC)

Date and Author from "described by source (P1343)" not displayed

Hello,

the properties "Date" (or maybe "year") and "Author" are not displayed for references of type "described by source (P1343)". You can see the problem for instance at File:Tristychius arcuatus Cast of FOS169.jpg (uses a different module but with a call to the get_references function of the present module).

Tried to fix the issue myself as it appeared fairly trivial, but seeing that my edits failed to solve the problem, I reverted myself lest I break something, and I now report the issue here.

Cheers! Rama (talk) 16:03, 30 January 2024 (UTC)

Module:Wikidata_art#L-974 and following:

:		cite_arg.url     = p.P854 or ''	-- reference URL (P854)
:		cite_arg.volume  = p.P478 or ''	-- volume (P478)
:		cite_arg.pages   = p.P304 or ''	-- pages (P304)
:

where you tried to add author (P50) only evaluate qualifiers of described by source (P1343) statements on Wikidata. For the result that I think you're aiming for I think the author (P50) (mainsnak) statement of the value item of the described by source (P1343) statement would have to be evaluated. This would mean loading more data. Jarekt, what do you think? (As far as I remember you were a bit wary of this in the past.) Best, --Marsupium (talk) 12:17, 1 February 2024 (UTC)

Wrong order of work locations

In the following case they are not ordered cronologically: {{#invoke:Wikidata art|debug|wikidata=Q1504435|field=work_location|lang=en}} gives: Cologne (1609); Antwerp (1610 - 1623); London (1623 - 1665) . --Marsupium (talk) 14:34, 3 June 2024 (UTC)

Another example: {{#invoke:Wikidata art|debug|wikidata=Q2244591|field=work_location|lang=en}} gives: The Hague ( - 1878); Amsterdam (1880); London (1888); Utrecht (1878 - ); Nieuwer-Amstel (1885 - )  Marsupium (talk) 10:59, 17 October 2024 (UTC)

Apart from the missing feature of considering others than a start time (P580) qualifier, I think this edit has caused the bug because the timestamps include sub-day precision, so they are longer than 11 bytes. --Marsupium (talk) 06:41, 22 October 2024 (UTC)

Hello Jarekt! In tracking down the bug above, I found that this and this edit have caused unprocessed timestamps from Wikibase snaks' datavalue.value.time not to be valid input for Module:Calendar._date2jdn() any more. I see two possible ways to fix this:

1. We make the input of Module:Calendar._date2jdn() more liberal again like this.
2. We prepare the timestamp input in Module:Wikidata date._qualifierDate() before to fit the requested format.

Which one do you prefer? Thanks in advance, --Marsupium (talk) 10:35, 22 October 2024 (UTC)

Marsupium My edit was definitely wrong as I forgot about longer strings. I dropped "or #ISOdate>11" part. --Jarekt (talk) 13:42, 22 October 2024 (UTC)

Thank you for the very fast fix! I guess it fixes a bulk of orders. In order to order cases like

{{#invoke:Wikidata art|debug|wikidata=Q2244591|field=work_location|lang=en}} currently giving

"The Hague ( - 1878); Amsterdam (1880); London (1888); Utrecht (1878 - ); Nieuwer-Amstel (1885 - ) "

chronologically, the getPropertyQual() functions would need to use end time (P582) and point in time (P585) qualifiers as well. Do you have any objections regarding the code adjustments needed for that? Best, --Marsupium (talk) 14:57, 22 October 2024 (UTC)

Bug: creator (P170): somevalue / qualifier: somevalue results in script error

creator (P170) somevalue / qualifier somevalue results in a script error. Example: File:Portret van Erckenraet Jansdr. van Berckenrode (1555-1610), 17de eeuw.jpg/Portrait of Erckenraet Jansdr. van Berckenrode (1555-1610) (Q121681981). This edit is a quick fix dropping such qualifiers. --Marsupium (talk) 09:51, 20 September 2025 (UTC)

 Done in Special:Diff/1153346573 (though the linked file no longer displays the error, I think due to d:Special:Diff/2408421043). @Marsupium: please tag your {{Edit request}} next time so it won’t go unnoticed for four months :) Lucas Werkmeister (talk) 18:34, 25 January 2026 (UTC)

Wait, you have permission to edit the module ^^ was there a reason you didn’t do it? Lucas Werkmeister (talk) 18:34, 25 January 2026 (UTC)

TBH I don't remember, probably trying to collect edits in order to reduce rerendering of millions of pages the module is transcluded on. --Marsupium (talk) 00:38, 27 January 2026 (UTC)

Okay, fair enough. I did two edits close together now and I think I remember someone pointing out the other day that MediaWiki ought to handle that reasonably well. Lucas Werkmeister (talk) 12:58, 27 January 2026 (UTC)

Inscription type's needs a Wikidata ID fix

{{Edit request}} inscription (P1684) somevalue / object of statement has role (P3831) caption (L-452) results in an error. The value "caption" was originally under Wikidata ID Q18585177 (with which it is currently transcluded on L-452), but it was later merged and replaced with Q12303449, causing inscriptions from artworks using inscription (P1684) somevalue / object of statement has role (P3831) caption (Q12303449) are no longer identified as captions at their files. Example: File:Anonymous Abbess Eufemia Szaniawska.jpg/Portrait of Abbess Eufemia Szaniawska (1712-1799). (Q29479932) – inscription direct link. I think that the problem could be resolved by editing L-452 to change the old Wikidata ID value from "Q18585177" to "Q12303449". Thank you in advance and best regards. --Stv26 (talk) 23:02, 23 January 2026 (UTC)

 Done --Lucas Werkmeister (talk) 18:30, 25 January 2026 (UTC)